Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed user profile error issue #231 #236

Merged
merged 3 commits into from
Oct 25, 2024

Conversation

AyushSharma72
Copy link
Contributor

@AyushSharma72 AyushSharma72 commented Oct 24, 2024

**fixed user profile error **

#231.:

Close #231

your code was only updating the user profile photo i have added an api call to update the user information which he fills in the form now it updates image and information both

Screenshot (285)

i have added this code since you have your api on render i tested the api in local env

Screenshot 2024-10-24 171721

then i changed the url so that it works when deployed on render

image

Checklist:

  • I have mentioned the issue number in my Pull Request.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have created a helpful and easy-to-understand README.md if it's a new page/tech stack.
  • I have gone through the contributing.md file before contributing.

Additional context (Mandatory):

Are you contributing under any Open-source programme?

  • I'm a GSSOC-EXT contributor
  • I'm a HACKTOBERFEST contributor

please add gssoc-ext and level2 before merge @Harshit7492

Copy link

netlify bot commented Oct 24, 2024

Deploy Preview for bitbox-in failed. Why did it fail? →

Name Link
🔨 Latest commit 88f87f4
🔍 Latest deploy log https://app.netlify.com/sites/bitbox-in/deploys/671bcabec9e73d0008f19a53

Copy link

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our chaotic CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Signed-off-by: Ayush Sharma <[email protected]>
@AyushSharma72
Copy link
Contributor Author

AyushSharma72 commented Oct 25, 2024

**fixed user profile error **

#231.:

Close #231

your code was only updating the user profile photo i have added an api call to update the user information which he fills in the form now it updates image and information both

Screenshot (285)

i have added this code since you have your api on render i tested the api in local env

Screenshot 2024-10-24 171721

then i changed the url so that it works when deployed on render

image

Checklist:

  • I have mentioned the issue number in my Pull Request.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have created a helpful and easy-to-understand README.md if it's a new page/tech stack.
  • I have gone through the contributing.md file before contributing.

Additional context (Mandatory):

Are you contributing under any Open-source programme?

  • I'm a GSSOC-EXT contributor
  • I'm a HACKTOBERFEST contributor

please add gssoc-ext and level2 before merge @Harshit7492

Please review this pr @Anuj3553

@Anuj3553 Anuj3553 self-requested a review October 25, 2024 16:48
@Anuj3553 Anuj3553 added gssoc-ext Extended contribution for GSSoC hacktoberfest-accepted Eligible contribution for Hacktoberfest rewards level2 Intermediate-level contribution or task hacktoberfest Open-source contribution during October for GSSoC labels Oct 25, 2024
@Anuj3553 Anuj3553 merged commit 020a761 into Bitbox-Connect:main Oct 25, 2024
0 of 4 checks passed
@Anuj3553
Copy link
Collaborator

Well done @AyushSharma72

Copy link

🎉🎉 Thank you for your contribution! Your PR #236 has been merged! 🎉🎉

@AyushSharma72 AyushSharma72 deleted the editprofile branch October 30, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc-ext Extended contribution for GSSoC hacktoberfest Open-source contribution during October for GSSoC hacktoberfest-accepted Eligible contribution for Hacktoberfest rewards level2 Intermediate-level contribution or task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

backend error in edit profile page
2 participants