Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Discussion page chat toggle, PR #233 (merge conflict solved) #234

Closed
wants to merge 2 commits into from

Conversation

AE-Hertz
Copy link
Contributor

[Feature Request]: change the discussion page to dark mode #200

Title: [Feature Request]: change the discussion page to dark mode

**Issue No.: #200 **

Close #200


Checklist:

  • I have mentioned the issue number in my Pull Request.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have created a helpful and easy-to-understand README.md if it's a new page/tech stack.
  • I have gone through the contributing.md file before contributing.

Additional context (Mandatory):

Are you contributing under any Open-source programme?

  • I'm a GSSOC-EXT contributor
  • I'm a HACKTOBERFEST contributor

Copy link

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our chaotic CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link

netlify bot commented Oct 24, 2024

Deploy Preview for tiny-brioche-d335f4 ready!

Name Link
🔨 Latest commit 3e8db18
🔍 Latest deploy log https://app.netlify.com/sites/tiny-brioche-d335f4/deploys/6719f3e65fec9e0008723993
😎 Deploy Preview https://deploy-preview-234--tiny-brioche-d335f4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Harshit7492
Copy link
Collaborator

please add visuals for changes you done @AE-Hertz

@AE-Hertz
Copy link
Contributor Author

@Harshit7492 yes, here is the demonstration.

Screen.Recording.2024-10-24.124045.mp4

@Anuj3553
Copy link
Collaborator

Hyy @AE-Hertz, There are some conflicts

image

@AE-Hertz
Copy link
Contributor Author

AE-Hertz commented Oct 25, 2024

@Anuj3553 hello, this is the same PR of #233 , I will request new PR with new branch so please merge this PR first before any as I am also refactoring code, I will request PR at 8am tomorrow. Thank you.

@Anuj3553
Copy link
Collaborator

Check your conflicts and push again code -->

image

@Anuj3553 Anuj3553 self-requested a review October 25, 2024 17:00
@Anuj3553 Anuj3553 added gssoc-ext Extended contribution for GSSoC hacktoberfest-accepted Eligible contribution for Hacktoberfest rewards level1 Beginner-level contribution or task hacktoberfest Open-source contribution during October for GSSoC labels Oct 25, 2024
@AE-Hertz
Copy link
Contributor Author

@Anuj3553 yes sir, i understood, I will request for PR at 8am tomorrow. Thank you.

@Anuj3553
Copy link
Collaborator

@Anuj3553 yes sir, i understood, I will request for PR at 8am tomorrow. Thank you.

Mention not and Take your time✌️

@AE-Hertz
Copy link
Contributor Author

@Anuj3553 sir requested new PR #257 merge this first , and i am closing this PR

@AE-Hertz AE-Hertz closed this Oct 26, 2024
Anuj3553 added a commit that referenced this pull request Oct 26, 2024
feat: Discussion page chat toggle, PR #233 (merge conflict solved) #234
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc-ext Extended contribution for GSSoC hacktoberfest Open-source contribution during October for GSSoC hacktoberfest-accepted Eligible contribution for Hacktoberfest rewards level1 Beginner-level contribution or task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: change the discussion page to dark mode
3 participants