Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed glitching issues #225

Merged
merged 4 commits into from
Oct 24, 2024
Merged

Conversation

ShivanshPlays
Copy link
Contributor

@ShivanshPlays ShivanshPlays commented Oct 23, 2024

Title and Issue number

Title: Solved several inconsistencies on the website, related ss are attached below.

Issue No.:

Close #206


Screenshots/Video (mandatory)

Screenshot 2024-10-23 041626
Screenshot 2024-10-23 042106
Screenshot 2024-10-23 042125
Screenshot 2024-10-23 222553

Now all those issues are solved as you can observe in the screen recording below:

Untitled.video.-.Made.with.Clipchamp.mp4

Checklist:

  • I have mentioned the issue number in my Pull Request.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have created a helpful and easy-to-understand README.md if it's a new page/tech stack.
  • I have gone through the contributing.md file before contributing.

Additional context (Mandatory):

Are you contributing under any Open-source programme?

  • I'm a GSSOC-EXT contributor
  • I'm a HACKTOBERFEST contributor

Copy link

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our chaotic CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@Harshit7492 Harshit7492 added gssoc-ext Extended contribution for GSSoC hacktoberfest-accepted Eligible contribution for Hacktoberfest rewards level3 Advanced or complex contribution/task hacktoberfest Open-source contribution during October for GSSoC labels Oct 24, 2024
@Harshit7492 Harshit7492 merged commit d448226 into Bitbox-Connect:main Oct 24, 2024
1 of 10 checks passed
Copy link

🎉🎉 Thank you for your contribution! Your PR #225 has been merged! 🎉🎉

Copy link

@MastanSayyad MastanSayyad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi program manager here, @Harshit7492 add level 2 label for this PR

@ShivanshPlays
Copy link
Contributor Author

ShivanshPlays commented Oct 25, 2024

@MastanSayyad I appreciate the review policies, although may I know the reason for this deprecation? I think the the level is justified. Please refer to the screenshots of bugs provided and screen recording of the them being solved in the PR

@MastanSayyad
Copy link

MastanSayyad commented Oct 25, 2024

hi @ShivanshPlays

  • The PR fixes glitching issues but which one is not specified + fixing glitches don't have level 3 unless complex one
  • Most of the code is formatted
  • have CSS modification with minor js logic which can be only applies as level 2
  • bugs have been fixed, not complex feature addrion or any backend or complex issue or bugs

image

@Anuj3553 Anuj3553 self-requested a review October 26, 2024 05:02
@Anuj3553 Anuj3553 added level2 Intermediate-level contribution or task and removed level3 Advanced or complex contribution/task labels Oct 26, 2024
@Anuj3553
Copy link
Collaborator

Hi program manager here, @Harshit7492 add level 2 label for this PR

Hyy @MastanSayyad, I'm changed the level2 from level3. Thankyou for reviewing the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc-ext Extended contribution for GSSoC hacktoberfest Open-source contribution during October for GSSoC hacktoberfest-accepted Eligible contribution for Hacktoberfest rewards level2 Intermediate-level contribution or task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: website glitching on community page and no navbar on login and signup pages.
4 participants