Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for commonkeychain in TSS recovery for eth-like coins #5103

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

simhonc
Copy link
Contributor

@simhonc simhonc commented Nov 6, 2024

Description

Link to Jira: https://bitgoinc.atlassian.net/browse/WP-2971

This is to prevent the error "Unsupported public key" when trying to create an unsigned sweep for a TSS SMC wallet (eth-like), and to allow the user to go ahead with creating their unsigned transaction.

Type of change: Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

These SDK changes have been tested in wallet-recovery-wizard by modifying in node_modules. TODO: use the SDK beta version from this PR to test.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My code compiles correctly for both Node and Browser environments
  • I have commented my code, particularly in hard-to-understand areas
  • My commits follow Conventional Commits and I have properly described any BREAKING CHANGES
  • The ticket or github issue was included in the commit message as a reference
  • I have made corresponding changes to the documentation and on any new/updated functions and/or methods - jsdoc
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@simhonc simhonc force-pushed the wp-2971-handle-ecdsa-commonkeychain-tss-recovery branch 4 times, most recently from b4a6882 to 24af379 Compare November 7, 2024 15:05
@simhonc simhonc force-pushed the wp-2971-handle-ecdsa-commonkeychain-tss-recovery branch from 45b4f8e to ff8325f Compare November 7, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant