frontend/qrcodescanner: improve qrscanner component #3048
Conversation
7c0b2f6 introduced a 300ms wait between the QrScanner creation and its start to fix a bug on re-renders of the component, but it seems not to be enough on certain devices, which still show the bug. It would be nice to change the 300ms fixed wait to a better way to know when the scanner is ready to be started but we could not find it. This commit improves the general structure of the component, to limit race conditions across re-renders and seems to improve the behavior and fix the bug with the tested devices.
Beerosagos
requested review from
thisconnect and
shonsirsha
and removed request for
thisconnect
|
I cannot reproduce the issue @strmci can you test this? |
I already tested it, @Beerosagos sent me the apk |
and? |
worked fine, on my Android |
|
|
||
| return () => { | ||
| (async() => { | ||
| while (loading.current) { |
There was a problem hiding this comment.
these while loops make me a little nervous 😅
There was a problem hiding this comment.
😂 I know it's not exactly the react way to solve a problem like this. Feel free to suggest changes
@strmci could you please test again? This is not exactly the same apk you tested, even tho there should not be any relevant difference <3 |
sure, can you please share apk with me? |
|
@thisconnect @Beerosagos |
7c0b2f6 introduced a 300ms wait between the QrScanner creation and its start to fix a bug on re-renders of the component, but it seems not to be enough on certain devices, which still show the bug.
It would be nice to change the 300ms fixed wait to a better way to know when the scanner is ready to be started but we could not find it.
This commit improves the general structure of the component, to limit race conditions across re-renders and seems to improve the behavior and fix the bug with the tested devices.