Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frontend use default scrollbars on macOS, iOS and Android #3044

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

thisconnect
Copy link
Collaborator

@thisconnect thisconnect commented Nov 11, 2024

Changed to use native scrollbars on macOS, iOS and Android.

Only keep custom scrollbar CSS for Linux and Windows.

@thisconnect
Copy link
Collaborator Author

rebased

@thisconnect thisconnect force-pushed the frontend-improve-scrollbars-macos branch from fdfb0a6 to 9a0ad1d Compare November 18, 2024 10:09
This allows to add platform specific CSS, i.e. for scrollbars
@thisconnect thisconnect force-pushed the frontend-improve-scrollbars-macos branch 4 times, most recently from 18febfe to d454ec2 Compare November 19, 2024 07:29
@thisconnect thisconnect marked this pull request as ready for review November 19, 2024 07:39
@thisconnect thisconnect changed the title Frontend improve scrollbars macos frontend use default scrollbars on macOS, iOS and Android Nov 19, 2024
@thisconnect
Copy link
Collaborator Author

thisconnect commented Nov 19, 2024

normal mode:

Bildschirmfoto 2024-11-19 um 08 55 34 Bildschirmfoto 2024-11-19 um 08 52 48 Bildschirmfoto 2024-11-19 um 08 53 37

@thisconnect
Copy link
Collaborator Author

dark mode:

Bildschirmfoto 2024-11-19 um 08 58 01 Bildschirmfoto 2024-11-19 um 08 58 12 Bildschirmfoto 2024-11-19 um 08 58 42

@thisconnect
Copy link
Collaborator Author

long dialogs:

Bildschirmfoto 2024-11-19 um 09 07 28 Bildschirmfoto 2024-11-19 um 09 07 08

@thisconnect thisconnect force-pushed the frontend-improve-scrollbars-macos branch from d454ec2 to e6c2d95 Compare November 19, 2024 08:16
@thisconnect
Copy link
Collaborator Author

seems there is a bug on linux/windows. I'll take a look what when wrong exactly.

Changed to use native scrollbars on macOS, iOS and Android.

Only keep custom scrollbar CSS for Linux and Windows.
@thisconnect thisconnect force-pushed the frontend-improve-scrollbars-macos branch from e6c2d95 to 701fbaa Compare November 19, 2024 13:32
@thisconnect
Copy link
Collaborator Author

@shonsirsha PTAL

shonsirsha
shonsirsha previously approved these changes Nov 19, 2024
Copy link
Collaborator

@shonsirsha shonsirsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Do you want to add the CSS comments for guide.module.css as there we have a "special" case?

The webkit-scrollbar-thumb always white regardless of platform & theme mode?

@shonsirsha shonsirsha dismissed their stale review November 20, 2024 10:36

scrollbar not white on guide

@thisconnect
Copy link
Collaborator Author

thisconnect commented Nov 25, 2024

@strmci I pused a small untested fix for Linux for the guide scrollbar . Could you test the guide scrollbar one more time? 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants