-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
frontend use default scrollbars on macOS, iOS and Android #3044
base: master
Are you sure you want to change the base?
frontend use default scrollbars on macOS, iOS and Android #3044
Conversation
22fd653
to
fdfb0a6
Compare
rebased |
fdfb0a6
to
9a0ad1d
Compare
This allows to add platform specific CSS, i.e. for scrollbars
18febfe
to
d454ec2
Compare
d454ec2
to
e6c2d95
Compare
seems there is a bug on linux/windows. I'll take a look what when wrong exactly. |
Changed to use native scrollbars on macOS, iOS and Android. Only keep custom scrollbar CSS for Linux and Windows.
e6c2d95
to
701fbaa
Compare
@shonsirsha PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Do you want to add the CSS comments for guide.module.css
as there we have a "special" case?
The webkit-scrollbar-thumb
always white
regardless of platform & theme mode?
@strmci I pused a small untested fix for Linux for the guide scrollbar . Could you test the guide scrollbar one more time? 🙏 |
Changed to use native scrollbars on macOS, iOS and Android.
Only keep custom scrollbar CSS for Linux and Windows.