eth: add signing function parameter to specify receive address case

[Tomasvrba]

No description provided.

[benma]

ChatGPT suggests this improvement to not allocate a String:

pub fn eth_identify_case(recipient_address: &str) -> pb::EthAddressCase {
    if recipient_address.chars().all(|c| c.is_ascii_uppercase()) {
        pb::EthAddressCase::Upper
    } else if recipient_address.chars().all(|c| c.is_ascii_lowercase()) {
        pb::EthAddressCase::Lower
    } else {
        pb::EthAddressCase::Mixed
    }
}

Please also add a test_eth_identify_case() unit test in the mod tests { block at the bottom of the file. ChatGPT can probably make this quickly too 😄

[Tomasvrba]

fixed, but had to add !c.is_ascii_alphabetic() since the original one doesn't work with numbers

    if recipient_address
        .chars()
        .all(|c| !c.is_ascii_alphabetic() || c.is_ascii_uppercase())
    {
        pb::EthAddressCase::Upper
    } else if recipient_address
        .chars()
        .all(|c| !c.is_ascii_alphabetic() || c.is_ascii_lowercase())
    {
        pb::EthAddressCase::Lower
    } else {
        pb::EthAddressCase::Mixed
    }

[benma]

Please also add a CHANGELOG in CHANGELOG-npm.md under 0.7.0 and in CHANGELOG-rust.md under 0.6.0

And also please configure your editor to run rustfmt on save - CI is complaining about unformatted code.

[Tomasvrba]

squash and merge when ready

edit: strange, looks like CI fails because of the missing optional argument in the examples/eth.rs want me to add it there? Any idea though why it fails when it's supposed to be optional?

[benma]

squash and merge when ready

edit: strange, looks like CI fails because of the missing optional argument in the examples/eth.rs want me to add it there? Any idea though why it fails when it's supposed to be optional?

@Tomasvrba there are no optional args. Option<...> means the argument type is Option<...>, not that it can be omitted. You can provide Some(...) or None as the value 😄 Please do that, CI needs to pass.

[Tomasvrba]

Please also add a CHANGELOG in CHANGELOG-npm.md under 0.7.0 and in CHANGELOG-rust.md under 0.6.0

And also please configure your editor to run rustfmt on save - CI is complaining about unformatted code.

I may be a rust noob, but this is bad naming and I will die on this hill, Option should be optional :P

[benma]

it's not just that, it also allows clients to specify the address case in the first place when signing a tx.

[benma]

Thanks! Please squash, then I'll merge.