Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenSearch 2.0 essential support #29

Merged
merged 5 commits into from
Jun 14, 2022
Merged

Conversation

Yury-Fridlyand
Copy link

@Yury-Fridlyand Yury-Fridlyand commented Jun 9, 2022

Changes:

  • Remove usage of deprecated search.remote settings.
  • Remove tests for _type validation in mapping APIs as it was removed from OpenSearch.
  • Remove validation for indices segments stats.
  • Rename master node role to cluster_manager as it was done in OpenSearch.
    CatMaster* API was duplicated into CatClusterManager*, but CatMaster* wasn't deleted. This provide backward compatibility. No new functionality added.

Notes:

Updated abstractions package is taken from #8.

Fully compatible with OpenSearch 2.0.0, OpenSearch 1.x and OpenDistro 1.13.x.

Related to:

opensearch-project#34
opensearch-project/opensearch-clients#12
opensearch-project/OpenSearch#2480

Signed-off-by: Yury Fridlyand [email protected]

`OpenSearch` 2.0 uses newer version of `Lucene` (9.0) which doesn't provide segments stats info.

Ref: opensearch-project/OpenSearch#2029 opensearch-project/OpenSearch#1109
See also history for `server/src/main/java/org/opensearch/index/engine/SegmentsStats.java` in `OpenSearch` repo.

Signed-off-by: Yury Fridlyand <[email protected]>
@@ -30,6 +30,10 @@

namespace OpenSearch.Client
{
/// <summary>
/// OpenSearch 2.0 has Lucene upgraded up to version 9.0 which doesn't provide memory info for segments.
/// All fields except `count` might be zeroed.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might or will?

… integration workflow to run tests on OpenSearch 2.0.

Signed-off-by: Yury Fridlyand <[email protected]>
"version": 2,
"contentHash": "76uDTVvMlMqIw47JMlnMXAYoYjMocRgirue/XJP+YQ2p/UGtWD9m8OTvhwCKWHtEO5pZG8+YqAzjEiUYLbKZwg==",
"source": null
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need a new line?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be, but it is an autogenerated file.

@Yury-Fridlyand Yury-Fridlyand merged commit 6bcdcef into dev-os-2.0-integ Jun 14, 2022
@Yury-Fridlyand Yury-Fridlyand deleted the dev-os-2.0 branch June 14, 2022 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants