Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue#16 #18

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Issue#16 #18

wants to merge 8 commits into from

Conversation

Degoot-AM
Copy link

This PR adds:

1 - age_limits as optional argument to contact_matrix
2- rename columns and rows to meet style of {socialmixr}

@Bisaloo
Copy link
Owner

Bisaloo commented Dec 6, 2024

Point 1 is addressed by #20.

For point 2, I would prefer to:

  • not have socialmixr as a dependency
  • deliver the matrices exactly as provided in the original paper since they is the stated scope of the paper

The best option is likely to add this feature in the shared contactmatrix class (socialcontactdata/contactmatrix#16), so all packages, including this one when #2 is addressed, can benefit from this feature.

The workflow would then be:

contactdata::contact_matrix(my_country) |>
  contactmatrix::merge_age_groups(new_groups = c("[0,10)", [10, 25)", "[25, 100)"))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants