Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💄 migrate DebugFloatingThemeButton to Material 3 #55

Conversation

Pavel-Sulimau
Copy link
Contributor

Description of the Change

  • DebugFloatingThemeButton button was still in Material 2 design because internally it used ToggleButtons.
    SegmentedButton is a Material 3 version of ToggleButtons, so it was used instead.
  • Set debugShowFloatingThemeButton to true in the example app.
  • Added Padding to the content of the HomePage in the example app to make the text better looking.
Before After

Benefits

More consistency in the package as the migration to Material 3 of the example app was done in version 3.4.1

Possible Drawbacks

I don't see any.

Verification Process

  • Made sure the tests were updated and all of them passed.
  • Tested the DebugFloatingThemeButton in the example app.

Applicable Issues

None.

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e835f1d) 94.38% compared to head (af6268c) 94.40%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #55      +/-   ##
==========================================
+ Coverage   94.38%   94.40%   +0.01%     
==========================================
  Files           7        7              
  Lines         303      304       +1     
==========================================
+ Hits          286      287       +1     
  Misses         17       17              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@BirjuVachhani BirjuVachhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BirjuVachhani BirjuVachhani merged commit f1565f1 into BirjuVachhani:main Jan 30, 2024
6 checks passed
@BirjuVachhani
Copy link
Owner

@Pavel-Sulimau Thank you for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants