-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python-pyhmmer: Update python-pyhmmer
PKGBUILD
#256
Conversation
python-pyhmmer
PKGBUILDpython-pyhmmer
PKGBUILD
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is git still nedded in make depends as the source is a git url
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution, could you please fix these minor problems?
@sukanka @starsareintherose @kbipinkumar : Good catch, thanks. I tested this locally on a computer with |
running namcap on final package archive shows following missing dependencies > namcap python-pyhmmer-0.11.0-1-x86_64.pkg.tar.zst | less | grep "E:"
python-pyhmmer E: Dependency python-typing_extensions detected and not included (python modules ['typing_extensions.Literal', 'typing_extensions.TypedDict', 'typing_extensions.Unpack'] needed in files ['usr/lib/python3.13/site-packages/pyhmmer/hmmer/_base.py', 'usr/lib/python3.13/site-packages/pyhmmer/hmmer/_jackhmmer.py'])
python-pyhmmer E: Dependency python-numpy detected and not included (python modules ['numpy'] needed in files ['usr/lib/python3.13/site-packages/pyhmmer/tests/test_doctest.py'])
|
if typing.TYPE_CHECKING:
if sys.version_info >= (3, 8):
from typing import Literal, TypedDict
else:
from typing_extensions import Literal, TypedDict # type: ignore |
Okay. So we can ignore the errors. |
@sukanka Can this PR be merged? |
the license install line in package () section needs to be modified as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
install -Dm644 ${srcdir}/${_name}-${pkgver}/COPYING "$pkgdir/usr/share/licenses/$pkgname/COPYING"
should be changed to install -Dm644 ${srcdir}/${_name}/COPYING "$pkgdir/usr/share/licenses/$pkgname/COPYING"
as well for calling the correct build directory
Involved packages
Details
Additional Note
This PR updates the
python-pyhmmer
PKGBUILD to the latest version. The last release (v0.11.0
) changed the build system fromsetuptools
to CMake andscikit-build-core
, so the build dependencies and process had to be updated.