Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add settings and heartbeats to stream #15

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

Gold872
Copy link
Member

@Gold872 Gold872 commented Nov 22, 2024

There's scenarios where you might want to listen to the incoming heartbeats or settings updates. For example, in the dashboard it listens to incoming UpdateSetting messages for changing modes.

Since these messages are never added to the stream, certain handshakes will never be completed since they are never added to the stream.

This is the fix for it.

@Levi-Lesches
Copy link
Member

I wanna see how long I can push this off because Salaj and Daniel are working on rewriting WrappedMessage in a more general way that can handle more of these special cases automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants