Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: haiqi96 <[email protected]>
  • Loading branch information
Bill-hbrhbr and haiqi96 authored Dec 4, 2024
1 parent 2b85f01 commit eda7d6c
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,13 @@
namespace {
using clp::streaming_compression::lzma::Compressor;

auto is_flush_action(lzma_action action) {
auto is_flush_action(lzma_action action) -> bool {
return LZMA_SYNC_FLUSH == action || LZMA_FULL_FLUSH == action || LZMA_FULL_BARRIER == action
|| LZMA_FINISH == action;
}

/**
* Initialize the Lzma compression stream
* Initialize the LZMA compression stream
* @param strm A pre-allocated `lzma_stream` object
* @param compression_level
* @param dict_size Dictionary size that specifies how many bytes of the
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ class Compressor : public ::clp::streaming_compression::Compressor {

/**
* Invoke lzma_code() repeatedly with the given flushing action until all
* encoded data is made available at the output block
* encoded data is made available at the output block buffer
*
* Once flushing starts, the workflow action needs to stay the same until
* flushing is signaled completed by LZMA (aka LZMA_STREAM_END is reached).
Expand All @@ -111,7 +111,7 @@ class Compressor : public ::clp::streaming_compression::Compressor {
auto flush_lzma(lzma_action flush_action) -> void;

/**
* Flushes the current compressed data in the lzma output buffer to the
* Flushes the current compressed data in the LZMA output buffer to the
* output file handler. Reset the compression buffer to receive new data.
*/
auto flush_stream_output_block_buffer() -> void;
Expand Down

0 comments on commit eda7d6c

Please sign in to comment.