Id creation

ID_column_creation.Rmd

@@ -0,0 +1,25 @@
+---
+title: "Id_column_creation"
+output: html_document
+---
+
+```{r setup, include=FALSE}
+knitr::opts_chunk$set(echo = TRUE)
+```
+
+
+## Id column creation
+
+cchsflow dev currently contains updated variables and variable details. These both have the new rows needed for id creation allowing for the same function call
+
+
+
+```{r}
+library(cchsflow)
+library(bllflow)
+
+
+rec_data <- rec_with_table(cchs2001_p, variables = variables, variable_details = variable_details)
+
+rec_data$id_year
+```

R/bll-flow-constructor-utility.R

@@ -89,7 +89,8 @@ bllflow_config_rec_data <- function(bllflow_object, config_env_name = NULL) {
       base::get(data_name),
       variables = bllflow_object$variables,
       variable_details = bllflow_object$variable_details,
-      database_name = data_name)
+      database_name = data_name,
+      attach_data_name = TRUE, id_role_name = list(var_name = "row_ID", feeder_vars="ADM_RNO"))
     assign(data_name, tmp_rec_data)
     save(list = data_name,
          file = file.path(config$data_dir,
@@ -121,6 +122,12 @@ bllflow_config_combine_data <- function(bllflow_object, config_env_name = NULL)
     load(file.path(config$data_dir, paste0(data_name, "_recoded", ".RData")))
     tmp_mod_data <- base::get(data_name)
     tmp_mod_data[["data_name"]] <- data_name
+    # Create unique row id 
+    if(config$unique_id){
+      id_cols <- select_vars_by_role("ID", bllflow_object$variables)
+
+      print("potato")
+    }
     if (is.null(tmp_working_data)) {
       tmp_working_data <- tmp_mod_data
     } else {

R/default_step_parsing.R

@@ -221,10 +221,8 @@ create_recipe <-
              variables) {
     # Check variable roles for the recipe creation
     # TODO bllflow support make this add to overall recipe
-    outcome_variable <-
-      as.character(variables[grepl("outcome,", 
-                                   variables[[pkg.globals$argument.Role]]), 
-                             pkg.globals$argument.Variables])
+    outcome_variable <- select_vars_by_role("outcome", variables)
+
     # TODO add a function for creating a proper formula
     recipe_formula <- paste(outcome_variable, "~ .")
 

R/label-utils.R

@@ -252,8 +252,11 @@ label_data <- function(label_list, data_to_label) {
           as.numeric(levels(data_to_label[[variable_name]])
           [data_to_label[[variable_name]]])
       } else {
+        tmp <- as.numeric(data_to_label[[variable_name]])
+        if(sum(is.na(tmp))!= length(tmp)){
         data_to_label[[variable_name]] <-
           as.numeric(data_to_label[[variable_name]])
+        }
       }
     }
     sjlabelled::set_label(data_to_label[[variable_name]]) <-