test table inference, fix imports/paths, and move odm #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zargot
force-pushed
the
246-table-infer
branch
2 times, most recently
from
694718e to
ccd5601
Compare
zargot
force-pushed
the
246-table-infer
branch
5 times, most recently
from
54fc68f to
bbb1446
Compare
zargot
changed the title
zargot
changed the title
zargot
changed the title
yulric
approved these changes
Jan 15, 2025
- move schema functions to schema module (to avoid circular dependency between utils and schemas) - cleanup test imports - remove remnants of sys path hack
tests can't access repo-assets from normal pkg/asset dir path when the package is installed (in dev. mode, in CI)
- add generated odm table files for table inference to avoid dependency between our validation schemas and the odm-specific table inference - move all odm-related constants and functions to its own module, including table inference - rename generate_schemas.py to generate_assets.py, since it now generates more than just schemas
zargot
force-pushed
the
246-table-infer
branch
from
bbb1446 to
ad0c313
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #246