Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grading PR #19

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Grading PR #19

wants to merge 1 commit into from

Conversation

opes
Copy link

@opes opes commented Oct 21, 2021

Bienventory Frontend Grading Notes

Note: Using the split view in the "Files Changed" tab of this PR will make it easier to see grading comments & suggestions.

DO NOT MERGE THIS PR

Notes

  • Superb tests!
  • Great work with the LoginProvider
  • Minor cleanup issues with unused lines of code
  • Great use of Material UI

Overall, great job!

@opes opes marked this pull request as ready for review October 21, 2021 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant