Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update email template as per further suggestions, add threadId in response #27

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Update email template as per further suggestions, add threadId in response #27

wants to merge 4 commits into from

Conversation

ankita-p17
Copy link

@ankita-p17 ankita-p17 commented Dec 18, 2024 •
edited
Loading

What

  1. Add thread id proof request to be sent via email
  2. Update in email template to of out-of-band verification request as per suggestion from NDI team.

Why

  1. To trace the proof request via email we need to add threadId

@ankita-p17 ankita-p17 requested a review from kinxa0 December 18, 2024 07:34
@ankita-p17 ankita-p17 changed the base branch from main to pipeline-implementation December 18, 2024 07:35
@ankita-p17 ankita-p17 changed the base branch from pipeline-implementation to main December 18, 2024 07:35
@ankita-p17 ankita-p17 changed the title Update email template as per further suggestions Update email template as per further suggestions, add threadId in response Dec 18, 2024
kinxa0
kinxa0 requested changes Dec 18, 2024
View reviewed changes
Copy link

@kinxa0 kinxa0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"the" is missing on line number 47. According to Pallavi's comment, it should be "Click on the ...."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kinxa0 kinxa0 kinxa0 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ankita-p17 @kinxa0