assignment code #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khushhalm
reviewed
Aug 20, 2024
.idea/dataSources.xml
Outdated
There was a problem hiding this comment.
Can you remove .idea dir from tracking since these are Code Editor files and nothing related to the PR?
khushhalm
reviewed
Aug 20, 2024
test/fixtures/files/.keep
Outdated
There was a problem hiding this comment.
Can you remove .keep files also from tracking?
khushhalm
reviewed
Aug 21, 2024
There was a problem hiding this comment.
Why have we created this Dockerfile?
Is it for personal use or this is a ask in the assignment?
There was a problem hiding this comment.
It was auto-generated when I created the project
khushhalm
reviewed
Aug 21, 2024
config/credentials.yml.enc
Outdated
khushhalm
reviewed
Aug 21, 2024
There was a problem hiding this comment.
Suggestion: Go through what all these config settings does and how they are helpful in what scenarios, if not done already.
There was a problem hiding this comment.
thanks for pointing it, read about them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
link: https://github.com/browserstack/tech-onboarding/tree/master/rapid-share-with-gems