fix: fix max lenght file secret issue #44
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thejurysays
suggested changes
Feb 28, 2024
api/secrets/secrets.go
Outdated
| secretInBytes := []byte(fileSecretContent) | ||
|
|
||
| if len(secretInBytes) > secretObj.maxFileSecretSize { | ||
| secretObj.log.Debug(fmt.Sprintf("%v%v%v: %v %v %v", secretPath, separator, secretTitle, "Secret Size:", len(secretInBytes), "is greater than allowed one", secretObj.maxFileSecretSize)) |
There was a problem hiding this comment.
looks good, lets change it to an error
secretObj.log.Error(fmt.Sprintf("%v%v%v: %v %v %v", secretPath, separator, secretTitle, "Secret file Size:", len(secretInBytes), "is greater than the maximum allowed size:", secretObj.maxFileSecretSize))
btfhernandez
force-pushed
the
secret-max-lenght-issue
branch
from
41c649a to
629350f
Compare
|
Note:Frogbot also supports Contextual Analysis, Secret Detection, IaC and SAST Vulnerabilities Scanning. This features are included as part of the JFrog Advanced Security package, which isn't enabled on your system. |
thejurysays
suggested changes
Feb 29, 2024
| @@ -59,9 +59,10 @@ The library supports retrieval of secrets from BeyondInsight/Password Safe versi | |||
| - default: 2 minutes | |||
| - required: False | |||
| - maxFileSecretSize | |||
There was a problem hiding this comment.
Could you add bytes to the end? maxFileSecretSizeBytes
| @@ -34,7 +34,7 @@ func main() { | |||
| maxFileSecretSize := 4000 | |||
|
|
|||
| // validate inputs | |||
| errorsInInputs := utils.ValidateInputs(clientId, clientSecret, apiUrl, clientTimeOutInSeconds, &separator, verifyCa, zapLogger, certificate, certificateKey, &retryMaxElapsedTimeMinutes, maxFileSecretSize) | |||
| errorsInInputs := utils.ValidateInputs(clientId, clientSecret, apiUrl, clientTimeOutInSeconds, &separator, verifyCa, zapLogger, certificate, certificateKey, &retryMaxElapsedTimeMinutes, &maxFileSecretSize) | |||
There was a problem hiding this comment.
maxFileSecretSizeBytes
| @@ -25,7 +25,7 @@ type UserInputValidaton struct { | |||
| var validate *validator.Validate | |||
|
|
|||
| // ValidateInputs is responsible for validating end-user inputs. | |||
| func ValidateInputs(clientId string, clientSecret string, apiUrl string, clientTimeOutinSeconds int, separator *string, verifyCa bool, logger logging.Logger, certificate string, certificate_key string, retryMaxElapsedTimeMinutes *int, maxFileSecretSize int) error { | |||
| func ValidateInputs(clientId string, clientSecret string, apiUrl string, clientTimeOutinSeconds int, separator *string, verifyCa bool, logger logging.Logger, certificate string, certificate_key string, retryMaxElapsedTimeMinutes *int, maxFileSecretSize *int) error { | |||
There was a problem hiding this comment.
maxFileSecretSizeBytes
| @@ -37,6 +37,10 @@ func ValidateInputs(clientId string, clientSecret string, apiUrl string, clientT | |||
| *retryMaxElapsedTimeMinutes = 2 | |||
| } | |||
|
|
|||
| if *maxFileSecretSize == 0 { | |||
| *maxFileSecretSize = 4000 | |||
There was a problem hiding this comment.
maxFileSecretSizeBytes
| @@ -46,7 +50,7 @@ func ValidateInputs(clientId string, clientSecret string, apiUrl string, clientT | |||
| ClientTimeOutinSeconds: clientTimeOutinSeconds, | |||
| Separator: *separator, | |||
| VerifyCa: verifyCa, | |||
| MaxFileSecretSize: maxFileSecretSize, | |||
| MaxFileSecretSize: *maxFileSecretSize, | |||
There was a problem hiding this comment.
maxFileSecretSizeBytes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.