Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: security findings resolved and fixed #130

Merged
merged 2 commits into from
Oct 1, 2024
Merged

fix: security findings resolved and fixed #130

merged 2 commits into from
Oct 1, 2024

Conversation

ivgonzalezc
Copy link
Contributor

@ivgonzalezc ivgonzalezc requested review from a team as code owners September 30, 2024 18:01
Fcogollo-BT
Fcogollo-BT previously approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@Fcogollo-BT Fcogollo-BT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

RanjitMishraBT
RanjitMishraBT previously approved these changes Oct 1, 2024
View reviewed changes
@ivgonzalezc ivgonzalezc dismissed stale reviews from RanjitMishraBT and Fcogollo-BT via 5c69477 October 1, 2024 14:21
Fcogollo-BT
Fcogollo-BT approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@Fcogollo-BT Fcogollo-BT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please check the errors on the failing scans of github actions

@ivgonzalezc ivgonzalezc merged commit efee74e into main Oct 1, 2024
9 of 13 checks passed
@ivgonzalezc ivgonzalezc deleted the BIPS-21230-security-findings branch October 1, 2024 18:52
@beyondtrust-release-app beyondtrust-release-app bot mentioned this pull request Oct 17, 2024
Merged
ivgonzalezc added a commit that referenced this pull request Jan 14, 2025
@ivgonzalezc
fix: security findings resolved and fixed (#130)
74a6cd2 
* fix: security findings resolved and fixed

* fix: security findings reversed on codeql
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fcogollo-BT Fcogollo-BT Fcogollo-BT approved these changes

@RanjitMishraBT RanjitMishraBT RanjitMishraBT approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ivgonzalezc @RanjitMishraBT @Fcogollo-BT