Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: registration page layout with photo upload #80

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

HeesooJun
Copy link

@HeesooJun HeesooJun commented Jan 12, 2025

행사 등록 페이지와 포토 업로드 화면 레이아웃 구현입니다.
image

하루 종일 체크 시
image

하루종일 미체크 시
image
image

등록하기 버튼 눌렀을 때, 구현 된 사항은 없습니다.

yuchem2
yuchem2 previously approved these changes Jan 12, 2025
Comment on lines +97 to +98
<label className="block text-base font-medium mb-2">행사 장소</label>
<input type="text" placeholder="위치 추가" className="w-full border rounded-lg px-4 py-2" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저희가 저장하는 정보에는 위치 위도, 경도 값이 필요해서 지도를 통해 위치를 찍을 수 있는 기능이 필요할 것 같습니다. 추후 추가해주세요.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

네네 추가하겠습니다.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저희가 이모티콘은 svg 형태로 관리하고 있습니다. 변경 부탁드려요

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

그 밑에 하신 말 못 보고 머지 안하고 추가푸시를 해버렸네요.. 수정하겠습니다

setPhotos(prevPhotos => prevPhotos.filter((_, i) => i !== index))
}

return (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

전체적으로 내부 컴포넌트를 분리하는게 좋을거 같아요

laggu
laggu previously approved these changes Jan 13, 2025
Copy link
Member

@laggu laggu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

일단 머지하고 추가 pr 로 수정해주시면 됩니다

@HeesooJun HeesooJun dismissed stale reviews from laggu and yuchem2 via 7c42cf1 January 16, 2025 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants