refactor: [BE] add promise return type to findByCategory function and update toJSON method additional fields #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
yuchem2
commented
Dec 8, 2024
yuchem2
commented
- FE에서 event 모델에 필요한 field를 전부 보내고 있지 않아 해당 건에 대한 수정입니다.
- 추가적으로 findByCategory 함수에 Promise가 없어 Promise 반영하였습니다.
… update toJSON method additional fields
joonamin
approved these changes
Dec 9, 2024
There was a problem hiding this comment.
확인해보니 event 관련한 모든 응답들에서 address 필드가 포함이 되어있질 않네요
@chsjen492 님 이번 PR 확인해주시고 모든 이벤트 API에 address 필드를 포함해주실 수 있으신가요?
|
|
응답이라고 말씀을 잘 못 드렸네요. 모델을 create하는 모든 API를 말씀드렸습니다! |
joonamin
pushed a commit
that referenced
this pull request
Dec 12, 2024
… update toJSON method additional fields (#41)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.