feat: create schedule middleware #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuchem2
reviewed
Dec 8, 2024
| @@ -5,8 +5,7 @@ import middlewares from '@/middlewares' | |||
|
|
|||
| const router: Router = asyncify(express.Router()) | |||
|
|
|||
| // TODO: add validator(eventId, authorId) | |||
| router.post('/', async (req: Request, res: Response) => { | |||
| router.post('/', middlewares.schedules.addScheduleMiddleware, async (req: Request, res: Response) => { | |||
There was a problem hiding this comment.
해당 미들웨어를 통해 등록된 행사와 관련된 일정만 생성할 수 있게 되는 것으로 확인했습니다.
제가 해당 토의가 정확하게 인지가 안되어서 그런데 해당 방향으로 결정된 것일까요?
There was a problem hiding this comment.
확실하게 결정되지 않은 상황이여서 일단 기본적인 외래키 제약조건만 검사할 수 있도록 설정해두었습니다 :)
추후에 해당 안건이 결정된다면 @/middlewares/schedules.ts/#addScheduleMiddleware 에 체이닝하여 설정할 예정이에요!
yuchem2
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#34 PR이 머지된 후에 리뷰 요청 드릴게요