[improve][client] PIP-224: Add getLastMessageIds API to deprecate getLastMessageId #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…LastMessageId Master Issue: apache#18616 Fixes apache#4940 NOTE: This implementation is different from the original design of PIP-224 that the method name is `getLastMessageIds` instead of `getLastTopicMessageId`. ### Motivation When a multi-topics consumer calls `getLastMessageId`, a `MultiMessageIdImpl` instance will be returned. It contains a map of the topic name and the latest message id of the topic. However, the `MultiMessageIdImpl` cannot be used in any place of the API that accepts a `MessageId` because all methods of the `MessageId` interface are not implemented, including `compareTo` and `toByteArray`. Therefore, users cannot do anything on such a `MessageId` implementation except casting `MessageId` to `MultiMessageIdImpl` and get the internal map. ### Modifications - Throw an exception when calling `getLastMessageId` on a multi-topics consumer instead of returning a `MultiMessageIdImpl`. - Remove the `MultiMessageIdImpl` implementation and its related tests. - Add the `getLastMessageIds` methods to `Consumer`. It returns a list of `TopicMessageId` instances, each of them represents the last message id of the owner topic. - Mark the `getLastMessageId` API as deprecated. ### Verifications - Modify the `TopicsConsumerImplTest#testGetLastMessageId` to test the `getLastMessageIds` for a multi-topics consumer. - Modify the `TopicReaderTest#testHasMessageAvailable` to test the `getLastMessageIds` for a single topic consumer.
14 tasks
BewareMyPower
force-pushed
the
bewaremypower/pip-224-get-last-msg-id
branch
2 times, most recently
from
b6e118a to
fd129bb
Compare
BewareMyPower
force-pushed
the
bewaremypower/pip-224-get-last-msg-id
branch
from
fd129bb to
0960047
Compare
Co-authored-by: Baodi Shi <[email protected]>
|
The pr had no activity for 30 days, mark with Stale label. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Master Issue: apache#18616
Fixes apache#4940
NOTE: This implementation is different from the original design of PIP-224 that the method name is
getLastMessageIdsinstead ofgetLastTopicMessageId.Motivation
When a multi-topics consumer calls
getLastMessageId, aMultiMessageIdImplinstance will be returned. It contains a map of the topic name and the latest message id of the topic. However, theMultiMessageIdImplcannot be used in any place of the API that accepts aMessageIdbecause all methods of theMessageIdinterface are not implemented, includingcompareToandtoByteArray.Therefore, users cannot do anything on such a
MessageIdimplementation except castingMessageIdtoMultiMessageIdImpland get the internal map.Modifications
getLastMessageIdon a multi-topics consumer instead of returning aMultiMessageIdImpl.MultiMessageIdImplimplementation and its related tests.getLastMessageIdsmethods toConsumer. It returns a list ofTopicMessageIdinstances, each of them represents the last message id of the owner topic.getLastMessageIdAPI as deprecated.Verifications
TopicsConsumerImplTest#testGetLastMessageIdto test thegetLastMessageIdsfor a multi-topics consumer.TopicReaderTest#testHasMessageAvailableto test thegetLastMessageIdsfor a single topic consumer.