Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add: Circular display connector (bottom05flip) #380
base: master
Are you sure you want to change the base?
Add: Circular display connector (bottom05flip) #380
Changes from 1 commit
d8924ae
de7b14f
41e0ad7
cfb70d7
eaaebe9
9b84f26
fd3a45d
4741afa
27eb475
241affa
d998297
068d849
0c6b179
fe67738
a45e893
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we learned it turns out that subtracting the forward voltage is pretty important
There also is a way to do this in one expression (instead of splitting the lower and upper bounds) and have tolerancing work correctly though it's a bit more complex. Can discuss further, might be interesting to try.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Applied the current suggestions.
Is there like an array operations like that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Division can be done as a range operation,
resistance = self.pwr.link().voltage / forward_current
. The problem is that forward current is a spec so the tolerance of resistance needs to shrink, whereas range division semantics here have tolerances expanding.There is
Range.cancel_multiply
, which does the right thing, but it needs to work on concrete values instead of RangeExpr. I'm thinking of maybe addingRangeExpr.cancel_multiply
, which can then be used here. Still thinking of syntax, mayberesistance = (1/forward_current).cancel_multiply(self.pwr.link().voltage)
? Possibly needs a better name too?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does that do element-wise multiplication? what does cancel mean here?