Fix issues Float32 and explicit Flux #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for fixing this, Olivier! I'm surprised so little modifications are
required to make this work with newer versions. I will take a look at this
when I'm back from holiday.
…On Wed, 3 Apr 2024, 15:52 Olivier Bonte, ***@***.***> wrote:
When you use these notebooks as you instruct now in the README.md, Two
minor changes have to be made
1. All floats must be of type Float32 to avoid warnings
2. You need to explicitly define Flux. for your ANN
This pull request is only needed if you want the example to be up to date
with Julia 1.10. If wanted, I can also upload the manifest.toml to increase
reproduciblility.
------------------------------
You can view, comment on, or merge this pull request online at:
#5
Commit Summary
- 384a108
<384a108>
Fix issues Float32 and explicit Flux
File Changes
(2 files <https://github.com/Beramos/Workshop-NeuralODE-2020/pull/5/files>
)
- *M* 02-NODEs.ipynb
<https://github.com/Beramos/Workshop-NeuralODE-2020/pull/5/files#diff-d866ad980ab59e4041397ddd9855f36feb5479c95ee56fe5b491c7c923fe9914>
(2158)
- *M* 03-hybrid.ipynb
<https://github.com/Beramos/Workshop-NeuralODE-2020/pull/5/files#diff-308662f169e5e715f2c3d157d085e2a3c47e43943c094616ebfa766d53b71181>
(486)
Patch Links:
- https://github.com/Beramos/Workshop-NeuralODE-2020/pull/5.patch
- https://github.com/Beramos/Workshop-NeuralODE-2020/pull/5.diff
—
Reply to this email directly, view it on GitHub
<#5>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACYUUXDO46FCHONZISXIAQTY3QCRLAVCNFSM6AAAAABFVLYHU2VHI2DSMVQWIX3LMV43ASLTON2WKOZSGIZDGMBQGU2TCMY>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you use these notebooks as you instruct now in the README.md, Two minor changes have to be made
This pull request is only needed if you want the example to be up to date with Julia 1.10. If wanted, I can also upload the manifest.toml to increase reproduciblility.