Fix nullable bug with txn bucket being legitamitely null - this is va…

…lid before a bucket is manually entered by user.
Benrnz · Jan 7, 2025 · 9c27c2a · 9c27c2a
1 parent 1d4409d
commit 9c27c2a
Show file tree

Hide file tree

Showing 4 changed files with 238 additions and 236 deletions.
diff --git a/BudgetAnalyser.Engine.UnitTest/Reports/BurnDownGraphAnalyserTest.cs b/BudgetAnalyser.Engine.UnitTest/Reports/BurnDownGraphAnalyserTest.cs
@@ -118,7 +118,7 @@ public void AnalyseShouldReturnZeroLineElementsTotalingToZero()
         [TestInitialize]
         public void TestInitialise()
         {
- Act();
+            Act();
         }
 
         private void Act()

diff --git a/BudgetAnalyser.Engine/Ledger/LedgerCalculation.cs b/BudgetAnalyser.Engine/Ledger/LedgerCalculation.cs
@@ -184,11 +184,11 @@ List<ReportTransaction> GetOverSpentTransactions() //private function
             do
             {
                 var currentDateCopy = currentDate;
-                foreach (var transaction in statement.Transactions.Where(t => t.Date == currentDateCopy))
+                foreach (var transaction in statement.Transactions.Where(t => t.Date == currentDateCopy && t.BudgetBucket is not null))
                 {
-                    if (runningBalances.ContainsKey(transaction.BudgetBucket))
+                    if (runningBalances.ContainsKey(transaction.BudgetBucket!))
                     {
-                        runningBalances[transaction.BudgetBucket] += transaction.Amount;
+                        runningBalances[transaction.BudgetBucket!] += transaction.Amount;
                     }
                 }
 
@@ -318,7 +318,7 @@ private decimal CalculateTransactionTotal(DateTime inclBeginDate, DateTime inclE
         }
         else
         {
-            transactions = transactions.Where(t => t.BudgetBucket.Code == bucketCode);
+            transactions = transactions.Where(t => t.BudgetBucket is not null && t.BudgetBucket.Code == bucketCode);
         }
 
         this.logger.LogInfo(_ =>

diff --git a/BudgetAnalyser.Engine/Statement/NamedTransaction.cs b/BudgetAnalyser.Engine/Statement/NamedTransaction.cs
@@ -26,7 +26,7 @@ public NamedTransaction(string name, bool isDebit = false)
             IsDebit = isDebit;
         }
 
-        public static NamedTransaction Empty => new NamedTransaction("");
+        public static NamedTransaction Empty => new NamedTransaction("default");
 
         /// <summary>
         ///     Gets the transaction type name.
-Original file line number
+Diff line change
@@ Expand Up @@
             [TestInitialize]
             public void TestInitialise()
             {
-     Act();
+                Act();
             }
             private void Act()
@@ Expand Down @@