Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added SeparableConv2d delete channel #27

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bpoppinga
Copy link

No description provided.

@Raukk
Copy link

Raukk commented Jun 6, 2019

Hey @bpoppinga,

I have just created a Fork of this project targeting Tensorflow.Keras.

I would be like to merge in this pull request to that Fork:
https://github.com/Raukk/tf-keras-surgeon

I could manually add it, but I would like to ensure you get attributed/credit.

Thanks

@FlatErik90
Copy link

Is there a chance this PR will be submitted anytime soon? I'm using this as a hotfix for some time now but it would be great to have it in the official repo. Using Raukk`s fork doesn't work for me due to TF version incompatibility.

@BenWhetton
Copy link
Owner

Sorry I didn't respond for so long. I haven't been actively maintaining this project for a while.
I'll try to review this in the next week.

@BenWhetton
Copy link
Owner

@bpoppinga Thanks for the contribution. The code looks generally up to the same standard as the rest of the codebase.
Would you have time to write one or two simple test cases for this code?

  • A test case which checks that the correct weights are removed from the layer itself
  • A test case for the code in _apply_delete_mask which propagates upstream pruning changes

I've only just make myself familiar with Separable2D layers so it'd probably take me a while to work out exactly what the pruning logic is supposed to do so in order to write the tests. If you could at least supply some inputs and expected outputs that would be very helpful.

christian-steinmeyer added a commit to christian-steinmeyer/keras-surgeon that referenced this pull request Jul 6, 2023
christian-steinmeyer added a commit to christian-steinmeyer/keras-surgeon that referenced this pull request Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants