Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump npm dep & rewrote deprecated sass #61

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Bump npm dep & rewrote deprecated sass #61

wants to merge 1 commit into from

Conversation

louisgcom
Copy link

No description provided.

@BrainBacon
Copy link

Why did you change the hex color codes to rgb instead?

@louisgcom
Copy link
Author

I didn't change hex color codes to rgb.
I updated darken and other sass color functions to color.adjust.
color.adjust is more precise, it does not round results.
Since results is a decimal and do not fall exactly on a hexadecimal color, it decides to keep the values ​​in rgb.

@BrainBacon
Copy link

Makes sense 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@louisgcom @BrainBacon