Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify cache #67

Merged
merged 10 commits into from
Oct 3, 2024
Merged

Simplify cache #67

merged 10 commits into from
Oct 3, 2024

Conversation

ljwoods2
Copy link
Collaborator

@ljwoods2 ljwoods2 commented Oct 3, 2024

Fixing error where StopIteration error is raised when sliced trajectory is used.

Changes made in this Pull Request:

  • Simplified reader by removing frame sequence acquired on slice, reader behaves like an ordinary reader now

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

@codecov Codecov
Copy link

codecov bot commented Oct 3, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 88.23529% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.78%. Comparing base (d57e287) to head (bda675d).
Report is 53 commits behind head on main.

Additional details and impacted files

@ljwoods2 ljwoods2 merged commit 6b35db8 into main Oct 3, 2024
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ljwoods2 @orbeckst