Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small bug and docs fixes #52

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Small bug and docs fixes #52

merged 1 commit into from
Jul 18, 2024

Conversation

ljwoods2
Copy link
Collaborator

@ljwoods2 ljwoods2 commented Jul 18, 2024 •
edited
Loading

Changes made in this Pull Request:

  • Fixes issue where last chunk written was incorrect values due to indexing
  • Allows 0 frames to be written (tests create writers without writing a frame)
  • Rewrite testfiles to have float32 values rather than int32

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

@codecov Codecov
Copy link

codecov bot commented Jul 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.88%. Comparing base (7e155e2) to head (df90890).
Report is 71 commits behind head on main.

Additional details and impacted files

@ljwoods2 ljwoods2 merged commit 3e50e96 into main Jul 18, 2024
23 checks passed
@ljwoods2 ljwoods2 deleted the test-debug branch July 23, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ljwoods2