Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workflows Base Module #229

Merged
merged 79 commits into from
Apr 4, 2023
Merged

Workflows Base Module #229

merged 79 commits into from
Apr 4, 2023

Conversation

cadeduckworth
Copy link
Contributor

@cadeduckworth cadeduckworth commented Jan 15, 2023 •
edited
Loading

close #237

@cadeduckworth
Copy link
Contributor Author

cadeduckworth commented Jan 15, 2023 •
edited by orbeckst
Loading

This PR will require that PR #217 or PR #227 is merged to complete testing of directory iteration function and workflows registry module.

@codecov
Copy link

codecov bot commented Jan 15, 2023 •
edited
Loading

Codecov Report

Merging #229 (099d6b5) into develop (b7d0b06) will increase coverage by 0.19%.
The diff coverage is 83.01%.

@@             Coverage Diff             @@
##           develop     #229      +/-   ##
===========================================
+ Coverage    79.96%   80.15%   +0.19%     
===========================================
  Files           13       15       +2     
  Lines         1847     1900      +53     
  Branches       282      291       +9     
===========================================
+ Hits          1477     1523      +46     
- Misses         280      286       +6     
- Partials        90       91       +1
Impacted Files Coverage Δ
mdpow/workflows/base.py 81.63% <81.63%> (ø)
mdpow/workflows/registry.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@orbeckst orbeckst mentioned this pull request Jan 17, 2023
Merged
@cadeduckworth
Copy link
Contributor Author

Requires merging of recent updates from develop before continuing work on tests.

@orbeckst
Copy link
Member

There are test failures related to SM25/SM26. Let me know when the PR is ready for review (or if you need input on something specific).

@cadeduckworth cadeduckworth mentioned this pull request Feb 21, 2023
Closed
@cadeduckworth cadeduckworth linked an issue Feb 21, 2023 that may be closed by this pull request
accept dihedrals_kws dictionary as input for use with workflows base and registry #237
Closed
@cadeduckworth
Copy link
Contributor Author

cadeduckworth commented Apr 1, 2023 •
edited
Loading

@orbeckst
ready for review

EDIT: some tests will need an update once more automated workflows are completed

orbeckst
orbeckst approved these changes Apr 4, 2023
View reviewed changes
Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, let me just merge to doc changes.

mdpow/workflows/base.py Outdated Show resolved Hide resolved
mdpow/workflows/base.py Outdated Show resolved Hide resolved
@orbeckst orbeckst self-assigned this Apr 4, 2023
@orbeckst orbeckst merged commit cafb300 into develop Apr 4, 2023
@orbeckst orbeckst deleted the workflows-base branch April 4, 2023 01:59
@orbeckst
Copy link
Member

orbeckst commented Apr 4, 2023

Hooray 🎉 , it's merged @cadeduckworth !

@cadeduckworth cadeduckworth mentioned this pull request Jun 28, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orbeckst orbeckst orbeckst approved these changes

Assignees

@orbeckst orbeckst

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

accept dihedrals_kws dictionary as input for use with workflows base and registry
2 participants
@cadeduckworth @orbeckst