-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Dihedral box #198
Fix Dihedral box #198
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #198 +/- ##
========================================
Coverage 78.53% 78.53%
========================================
Files 11 11
Lines 1677 1677
Branches 250 250
========================================
Hits 1317 1317
Misses 276 276
Partials 84 84
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am going to approve without asking for the obligatory "could you please test this" because I know that it's tested in MDA — that's why using existing (trustworthy) libraries is good!
I think you need to update your own branch because lot's of old commits are showing up. The squash merge just dealt with it but in the future it would be good to have clean PRs for review. |
I added a box argument to calc_dihedrals similar to what is present in MDAnalysis