Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make EnsembleAtomGroup.ensemble() return original #192

Merged
merged 4 commits into from
Sep 10, 2021

Conversation

ALescoulie
Copy link
Contributor

Quick fix for EnsembleAtomGroup making ensemble() method reference original.

@ALescoulie ALescoulie requested a review from orbeckst September 10, 2021 02:10
@ALescoulie ALescoulie mentioned this pull request Sep 10, 2021
2 tasks
@codecov
Copy link

codecov bot commented Sep 10, 2021

Codecov Report

Merging #192 (61cfa64) into develop (5a9b22f) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #192      +/-   ##
===========================================
- Coverage    77.64%   77.60%   -0.05%     
===========================================
  Files           10       10              
  Lines         1606     1603       -3     
  Branches       227      226       -1     
===========================================
- Hits          1247     1244       -3     
  Misses         276      276              
  Partials        83       83              
Impacted Files Coverage Δ
mdpow/analysis/ensemble.py 97.04% <100.00%> (-0.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a9b22f...61cfa64. Read the comment docs.

Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turn the ensemble into a managed property (you can just apply my suggestions) and add a test for EnsembleAtomGroup.ensemble.

mdpow/analysis/ensemble.py Show resolved Hide resolved
mdpow/analysis/ensemble.py Outdated Show resolved Hide resolved
@orbeckst
Copy link
Member

I applied the suggestion, but need to check the tests.

@orbeckst orbeckst merged commit 6e8a73d into Becksteinlab:develop Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants