Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Ensemble Docs #189

Merged
merged 1 commit into from
Sep 9, 2021
Merged

Fix Ensemble Docs #189

merged 1 commit into from
Sep 9, 2021

Conversation

ALescoulie
Copy link
Contributor

Fixing Issue #188

@codecov
Copy link

codecov bot commented Sep 9, 2021 •
edited
Loading

Codecov Report

Merging #189 (2ae04e3) into develop (d4767ee) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #189   +/-   ##
========================================
  Coverage    77.64%   77.64%           
========================================
  Files           10       10           
  Lines         1606     1606           
  Branches       227      227           
========================================
  Hits          1247     1247           
  Misses         276      276           
  Partials        83       83
Impacted Files Coverage Δ
mdpow/analysis/ensemble.py 97.08% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4767ee...2ae04e3. Read the comment docs.

@ALescoulie ALescoulie requested a review from orbeckst September 9, 2021 18:41
orbeckst
orbeckst approved these changes Sep 9, 2021
View reviewed changes
Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@orbeckst orbeckst merged commit b7839f5 into Becksteinlab:develop Sep 9, 2021
@orbeckst orbeckst linked an issue Sep 10, 2021 that may be closed by this pull request
fix ensemble docs for add_system() example #188
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orbeckst orbeckst orbeckst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix ensemble docs for add_system() example
2 participants
@ALescoulie @orbeckst