chore: properly destroy event

BecauseOfProg · Sep 23, 2023 · d740147 · d740147
1 parent 9cc8d2b
commit d740147
Showing 1 changed file with 12 additions and 6 deletions.
diff --git a/components/ScrollToTop.vue b/components/ScrollToTop.vue
@@ -33,14 +33,20 @@ export default {
     }
   },
   mounted () {
-    document.addEventListener('scroll', (event) => {
-      if (typeof window === 'undefined') { return }
-      const top = window.pageYOffset || event.target.scrollTop || 0
-      this.active = top > this.threshold
-    })
+    document.addEventListener('scroll', this.checkScroll)
   },
   beforeDestroy () {
-    document.removeEventListener('scroll', () => {})
+    document.removeEventListener('scroll', this.checkScroll)
+  },
+  methods: {
+    checkScroll (event) {
+      if (typeof window === 'undefined') {
+        return
+      }
+
+      const top = window.pageYOffset || event.target.scrollTop || 0
+      this.active = top > this.threshold
+    }
   }
 }
 </script>