Less logging of DstvExceptions to the console #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mstrdk
approved these changes
Jul 13, 2023
| @@ -17,6 +17,7 @@ public static async Task<IEnumerable<DstvElement>> GetElementsAsync(ReaderContex | |||
| foreach (var holeNote in holeBlocks.SelectMany(holeList => holeList)) | |||
| try | |||
| { | |||
| if (holeNote.Equals(ContourType.BO.ToString(), StringComparison.Ordinal)) continue; | |||
There was a problem hiding this comment.
I'd prefer the use of the nameof operator in these cases (e.g. nameof(ContourType.BO)), but that's pretty personal...
tluijken
requested changes
Jul 14, 2023
| @@ -17,6 +17,7 @@ public static async Task<IEnumerable<DstvElement>> GetElementsAsync(ReaderContex | |||
| foreach (var holeNote in holeBlocks.SelectMany(holeList => holeList)) | |||
| try | |||
| { | |||
| if (holeNote.Equals(ContourType.BO.ToString(), StringComparison.Ordinal)) continue; | |||
| @@ -55,6 +57,7 @@ public static async Task<IEnumerable<DstvElement>> GetElementsAsync(ReaderContex | |||
| foreach (var bendNote in bendBlocks.SelectMany(bendList => bendList)) | |||
| try | |||
| { | |||
| if (bendNote.Equals(ContourType.KA.ToString(), StringComparison.Ordinal)) continue; | |||
There was a problem hiding this comment.
I feel like there is a lot of repetition going on here...should we make a generic function for this?
There was a problem hiding this comment.
I've simplified the code
|
@EjaYF Can you rebase and resolve the conflicts? |
EjaYF
force-pushed
the
feature/ErrorConsoleLogFix
branch
from
9aa1bbd
to
0300106
Compare
tluijken
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix addresses issues where DstvExceptions appear in the console log unnecessary.