Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support modifying head element textContent property #16

Merged

Conversation

sachamasry
Copy link

This adds a simple function push_content, making a call to update the textContent property and not an attribute.

On the client side, the index.ts function, applyToElement adds a new check, for an attribute of 't', setting the textContent to the new value, or appending to it.

@BartOtten BartOtten changed the title Commit of changes necessary to modify head element textContent property, in addition to attributes. feat: support modifying head element textContent property Dec 16, 2024
@BartOtten BartOtten merged commit 306cee4 into BartOtten:main Dec 16, 2024
1 of 5 checks passed
@BartOtten
Copy link
Owner

BartOtten commented Dec 16, 2024

@sachamasry thanks for the contribution :)

Any chance you committed under the wrong Git user? If so, let me know and I'll fix the contribution link.

@sachamasry
Copy link
Author

sachamasry commented Dec 18, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants