Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

indicate homed status #31

Merged
merged 1 commit into from
May 29, 2024

Conversation

ronlawrence3
Copy link

@BarbourSmith - a simple update to indicate the homed status of the maslow based on my $MINFO command.

I intend to remove this message in favor of making the maslow tab UI react to the state and present options but for now this may help users see that they need the re-hang dance.

image

image

image

@BarbourSmith
Copy link
Owner

I 100% agree with the need to address this issue, but is there any way we could make something a little more polished feeling? I'm not 100% sure what that would be.

Maybe a popup if the arrow buttons are pressed when the machine is not homed?

@ronlawrence3
Copy link
Author

Yep, I agree. This was a "quick and dirty" to accomplish just notification to people that the thing is not homed... My current branch is working on a UI where if the machine is not homed, it walks the user right through the "rehang dance" (no, I don't call it that :) ) . I'll just take the time to get that on this PR and @ you again when its ready. I'm still working on allowing Z and config dialogs to open from the wizard..

BarbourSmith added a commit that referenced this pull request May 29, 2024
Builds on #31 to make the alerts more subtle
@BarbourSmith BarbourSmith merged commit c6e8c32 into BarbourSmith:Maslow-Main May 29, 2024
1 check passed
@BarbourSmith
Copy link
Owner

Merged in #33 in a slightly modified form so that I could get it into this week's update. Great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants