Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File upload freshen up #108

Draft
wants to merge 7 commits into
base: Maslow-Main
Choose a base branch
from

Conversation

md8n
Copy link

@md8n md8n commented Jan 22, 2025

  • Remove a lot of the on* event handlers from the HTML back out to code, where they belong
  • A few Ids changed/added into the HTML to enable the removal of the on* attributes
  • Change those event handlers methods to be as simple as possible (no parameters), taking advantage of the way browsers behave to minimise duplication of event handler creation
  • Change calls to SendGetHttp, SendFileHttp to use cmd instead of url as the values are NOT URLS but commands
  • Some error handling around parsing responses
  • Some checking around getting setting values etc. out of elements
  • Minor clean up of app.js because the gulp linter complained about it
  • Moved a few functions between files so they're closer to their actual usage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant