cantina/159

[mejango]

Description

What does this PR: do, how, why?

Limitations & risks

Are there any trade-off or new vulnarbility surface based on theses changes?

Check-list

• Tests are covering the new feature
• Code is natspec'd
• Code is linted and formatted
• I have run the test locally (and they pass)
• I have rebased to the latest main commit (and tests still pass)

Interactions

These changes will impact the following contracts:

• Directly:

• Indirectly:

[xBA5ED]

Another potential solution could be that instead of minting to each recipient in the loop (and in the leftOverTokenCount check) we mint the tokenCount to the controller before the loop, then in the loop we only do transfers instead of mints.

Would also allow us to set pendingReservedTokenBalanceOf[projectId] to zero before the loop so the totalTokenSupplyWithReservedTokensOf is correct at all times.

[mejango]

Another potential solution could be that instead of minting to each recipient in the loop (and in the leftOverTokenCount check) we mint the tokenCount to the controller before the loop, then in the loop we only do transfers instead of mints.

Would also allow us to set pendingReservedTokenBalanceOf[projectId] to zero before the loop so the totalTokenSupplyWithReservedTokensOf is correct at all times.

i prefer this. ill play

[xBA5ED]

LGTM