slither fixes #32
Merged
slither fixes #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xBA5ED
reviewed
Aug 27, 2024
| error JBBuybackHook_InvalidTwapWindow(uint256 value, uint256 min, uint256 max); | ||
| error JBBuybackHook_PoolAlreadySet(IUniswapV3Pool pool); | ||
| error JBBuybackHook_SpecifiedSlippageExceeded(uint256 amount, uint256 minimum); | ||
| error JBBuybackHook_Unauthorized(address caller); |
There was a problem hiding this comment.
nit: I feel like the JBBuybackHook_ prefix doesn't really make sense for the Unauthorized error. Since its used in a lot of places and this would make it so each contract gets its own signature for this error, for UIs it feels more comfortable if we use the same error(s) in lots of places.
There was a problem hiding this comment.
Makes sense.
counterpoint would be that a UI would want to know which unauthorized is being triggered, else it’s unclear where the error comes from.
xBA5ED
reviewed
Aug 28, 2024
xBA5ED
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixed slither
Limitations & risks
Are there any trade-off or new vulnarbility surface based on theses changes?
Check-list
Interactions
These changes will impact the following contracts:
Directly:
Indirectly: