rm peerChainId

Bananapus · Jun 19, 2024 · 45b116a · 45b116a
1 parent d33f35f
commit 45b116a
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 18 deletions.
diff --git a/src/JBCCIPSucker.sol b/src/JBCCIPSucker.sol
@@ -42,15 +42,6 @@ contract JBCCIPSucker is JBSucker {
         JBSucker(directory, tokens, permissions, atbMode)
     {}
 
-    //*********************************************************************//
-    // ------------------------ external views --------------------------- //
-    //*********************************************************************//
-
-    /// @notice Returns the chain on which the peer is located.
-    /// @return chainId of the peer.
-    /// TODO: Check this, maybe remove from impl or return dummy info to keep interface the same.
-    function peerChainID() external view virtual override returns (uint256 chainId) {}
-
     //*********************************************************************//
     // --------------------- internal transactions ----------------------- //
     //*********************************************************************//
@@ -63,7 +54,6 @@ contract JBCCIPSucker is JBSucker {
         internal
         override
     {
-        // TODO: Require transportPayment, CCIP expects to be paid
         if (transportPayment == 0) {
             revert UNEXPECTED_MSG_VALUE();
         }
@@ -76,7 +66,6 @@ contract JBCCIPSucker is JBSucker {
         uint64 nonce = ++outbox[token][remoteSelector].nonce;
 
         // Ensure the token is mapped to an address on the remote chain.
-        // TODO: re-enable
         if (remoteToken.addr == address(0)) {
             revert TOKEN_NOT_MAPPED(token);
         }
@@ -116,7 +105,7 @@ contract JBCCIPSucker is JBSucker {
         /* messageId =  */
         router.ccipSend{value: fees}({destinationChainSelector: remoteSelector, message: evm2AnyMessage});
 
-        // TODO: Refund remaining balance.
+        // Refund remaining balance.
         (bool sent,) = msg.sender.call{value: msg.value - fees}("");
         if (!sent) revert FailedToRefundFee();
 

diff --git a/src/JBSucker.sol b/src/JBSucker.sol
@@ -402,10 +402,6 @@ abstract contract JBSucker is JBPermissioned, ModifiedReceiver, IJBSucker {
         return remoteTokenFor[token].addr != address(0);
     }
 
-    /// @notice Returns the chain on which the peer is located.
-    /// @return chain ID of the peer.
-    function peerChainID() external view virtual returns (uint256);
-
     //*********************************************************************//
     // --------------------- internal transactions ----------------------- //
     //*********************************************************************//

diff --git a/src/interfaces/IJBSucker.sol b/src/interfaces/IJBSucker.sol
@@ -4,8 +4,6 @@ pragma solidity ^0.8.0;
 import {JBTokenMapping} from "../structs/JBTokenMapping.sol";
 
 interface IJBSucker {
-    function peerChainID() external view returns (uint256 chainId);
-
     function isMapped(address token) external view returns (bool);
 
     function prepare(