jlesueur/guardrail metrics configuration #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jlesueur
commented
Feb 10, 2021
jlesueur
commented
- Barebones Metric implementation
- a couple bug fixes.
- no need to double implement.
- WIP - really messy, does not work.
- WIP metric configuration.
- A Metric interface describing data included in a metric - A Metric output interface for emitting metrics - Add Metrics to the socket protocol - Add a Json Metric file format (log file, each line is valid json, but file is not valid json) - hard code the metric file in the configuration - Add a metric to MethodCall to track calls to deprecated methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.