Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Enhancement : Added sorting option in each column #76

Merged
merged 2 commits into from
Jun 7, 2024
Merged

Conversation

mukilan2815
Copy link
Contributor

image

When user press the column name , it will sort in ascending , if user presses it again then it will sort in descending order.
GSSOC'24

Copy link

vercel bot commented Jun 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
diabetes-prediction ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 5, 2024 9:54am

@BamaCharanChhandogi
Copy link
Owner

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link
Owner

@BamaCharanChhandogi BamaCharanChhandogi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you update the package JSON file for the client and server?

@mukilan2815
Copy link
Contributor Author

Just added some packages like mantine and loadsh for better performance.

@BamaCharanChhandogi
Copy link
Owner

By default, the sorting icon is not visible. I think we can not understand whether the sorting functionality is available or not.
So I think by default icon should be visible.

@mukilan2815
Copy link
Contributor Author

Fixed the changes check it now and close this under GSSOC'24
#71

Copy link
Owner

@BamaCharanChhandogi BamaCharanChhandogi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

@BamaCharanChhandogi BamaCharanChhandogi merged commit 82bed6b into BamaCharanChhandogi:main Jun 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants