Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added social media icons #138

Merged
merged 2 commits into from
Jul 10, 2024
Merged

Added social media icons #138

merged 2 commits into from
Jul 10, 2024

Conversation

Soumya6Tiwari
Copy link
Contributor

Added Suitable social media profile links such as github, quora etc in the footer section
Screenshot 2024-07-09 023127

Copy link

vercel bot commented Jul 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
diabetes-prediction ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 9, 2024 6:57pm

@BamaCharanChhandogi
Copy link
Owner

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@Soumya6Tiwari
Copy link
Contributor Author

@BamaCharanChhandogi kindly review the PR

Copy link
Owner

@BamaCharanChhandogi BamaCharanChhandogi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You do not have to change package file.
Please revert it.

@Soumya6Tiwari
Copy link
Contributor Author

@BamaCharanChhandogi But I only made changes in footer.jsx
Screenshot 2024-07-09 132448
To add github icon , and quora icon it was necessary to import them from react - icons .

@BamaCharanChhandogi
Copy link
Owner

@BamaCharanChhandogi But I only made changes in footer.jsx Screenshot 2024-07-09 132448 To add github icon , and quora icon it was necessary to import them from react - icons .

This is all right. I am saying why did you change the package Json file. I think It was by mistake. you can undo changes to that file. I mean revert.

@Soumya6Tiwari
Copy link
Contributor Author

@BamaCharanChhandogi Ok I reverted back the changes

Copy link
Owner

@BamaCharanChhandogi BamaCharanChhandogi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@BamaCharanChhandogi BamaCharanChhandogi merged commit 03d85cb into BamaCharanChhandogi:main Jul 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants