Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed hero section #118

Closed

Conversation

Utsavladia
Copy link

@Utsavladia Utsavladia commented Jun 25, 2024

#115
Fixed hero section for both mobile as well as large screeen sizes...

image
image

Copy link

vercel bot commented Jun 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
diabetes-prediction ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 3, 2024 4:18am

@BamaCharanChhandogi
Copy link
Owner

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link
Owner

@BamaCharanChhandogi BamaCharanChhandogi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you change the package.json file?
This design is not responsive.

image

@Utsavladia
Copy link
Author

@BamaCharanChhandogi
I removed the changes of package.lock.json and
Made it responsive although the reposive was needed for navbar not hero section still i fixed it...

image

@BamaCharanChhandogi
Copy link
Owner

The navbar code is perfect when I reload the site extra space showing. please fix it.

image

@Utsavladia
Copy link
Author

@BamaCharanChhandogi
I have fixed it... The problem is little bit related to late rendering of the GotoTop button at the bottom right

Recording.2024-06-26.235133.1.mp4

@BamaCharanChhandogi
Copy link
Owner

Fix Merge Conflicts then I can merge.

@Utsavladia
Copy link
Author

@BamaCharanChhandogi
fixed

@BamaCharanChhandogi
Copy link
Owner

It still has not fixed that bug. Now, after changes giving new errors in the console.
I am closing this PR. See you in the new issue/PR. Thanks.

image

@Utsavladia
Copy link
Author

Utsavladia commented Jul 3, 2024

@BamaCharanChhandogi
This is because of the new chagnes made in main branch after this PR.
should i create a new PR on this issue with the changes based on latest branch to avoid new errors....?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants