Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BAH-2306 | Show different range for lab-test #444

Closed
wants to merge 1 commit into from

Conversation

swe-vmd
Copy link
Contributor

@swe-vmd swe-vmd commented Sep 15, 2022

No description provided.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@gsluthra
Copy link
Contributor

For context on this bug/request see: #441

@gsluthra
Copy link
Contributor

@TriumfM Thanks for raising the PR. Can you please sign the CLA. Please ensure your email address of git commits matches your github email address which you will use to sign the CLA digitally. This is a one time activity. thanks!

@swe-vmd
Copy link
Contributor Author

swe-vmd commented Sep 20, 2022

@CLAassistant @gsluthra the CLA is accepted!

@gsluthra gsluthra changed the title BUG-2306 | Show different range for lab-test BAH-2306 | Show different range for lab-test Sep 20, 2022
@gsluthra
Copy link
Contributor

More details here: https://bahmni.atlassian.net/browse/BAH-2306

@binduak
Copy link
Contributor

binduak commented Sep 20, 2022

@swe-vmd CLA is still pending. As @gsluthra pointed out "your email address of git commits matches your github email address which you will use to sign the CLA digitally".

PR Build is failing with lint issue.
https://github.com/Bahmni/openmrs-module-bahmniapps/actions/runs/3060698964/jobs/4995642567

@swe-vmd swe-vmd force-pushed the bug-2306 branch 2 times, most recently from 0cdef08 to f8d8e3a Compare September 21, 2022 11:42
@swe-vmd
Copy link
Contributor Author

swe-vmd commented Sep 21, 2022

@swe-vmd CLA is still pending. As @gsluthra pointed out "your email address of git commits matches your github email address which you will use to sign the CLA digitally".

PR Build is failing with lint issue. https://github.com/Bahmni/openmrs-module-bahmniapps/actions/runs/3060698964/jobs/4995642567

@binduak I think now it should be okay.

@swe-vmd
Copy link
Contributor Author

swe-vmd commented Sep 26, 2022

@binduak & @gsluthra this is the last push, I think now is ok but the pipeline is not running.
https://github.com/Bahmni/openmrs-module-bahmniapps/actions/runs/3097513516

@binduak
Copy link
Contributor

binduak commented Sep 26, 2022

@swe-vmd i ran the PR checks again. CLA is still pending for the PR
Github is identifying both @swe-vmd and @TriumfM as different users/mail id's. Please check and resolve to get the CLA signed.
or you can copy the PR changes on to a different branch and commit with @swe-vmd user, and a raise a new PR. This should fix the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants