Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bug: getAll missing observations #138

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix bug: getAll missing observations #138

wants to merge 2 commits into from

Commits on Jul 20, 2022

  1. fix bug getAll missing observations 

    The shortcut on lines 67-69 cause an unexcpected result where, when getAll has numberOfAccessions set, observations for orders will only be attached to orders if their encounter is dated after the last encounter reached by this loop. The solution seems to be to just remove the shortcut.
    @annooritdept
    annooritdept authored Jul 20, 2022
    Configuration menu
    Copy the full SHA
    a8029c5 View commit details
    Browse the repository at this point in the history

  2. Update LabOrderResultsServiceImpl.java 

    Previous bugfix was wrong, would have ignored numberOfAccessions altogether. This is possibly better. I apologize, I don't have a development system set up to test this.
    @annooritdept
    annooritdept authored Jul 20, 2022
    Configuration menu
    Copy the full SHA
    5b9c47e View commit details
    Browse the repository at this point in the history