Ace Editor Docs Review #427
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v-excelsior
requested changes
Apr 6, 2023
Comment on lines
+23
to
+25
| <p align="center"> | ||
| <img src="./example-images/ace_editor_component_settings.jpg" alt="Ace editor settings" width="780"/> | ||
| </p> |
There was a problem hiding this comment.
There is no need for a Settings image. It could be changed at any time and looks not pretty.
Comment on lines
+13
to
+19
| The editor supports 6 graphical themes: | ||
| 1. Github | ||
| 2. Chrome | ||
| 3. Monokai | ||
| 4. Nord | ||
| 5. Dark Twilight | ||
| 6. Idle Fingers |
There was a problem hiding this comment.
I don't think this could be helpful. We already have possible values in the Properties table, and it is just a duplication of information.
But, as @Valodya offered we could add a section with images of how these themes look.
Depending on how much space it takes we could place it here(if it's not huge) or after tables.
| Ace Editor is a component of Backendless UI-Builder designer. The Ace Editor component is the high-performance code editor for the web. This component is created using the [react-ace](https://www.npmjs.com/package/react-ace) library. | ||
| Ace is the embeddable code editor which supports the syntax highlighting for the following programming languages: Java, JavaScript, TypeScript, Python, JSON, PHP, C, C++, C#, Ruby, HTML, CSS. | ||
|
|
||
| When this component is deployed it can highlight only one programming language that was set by developer in the Logic of the Backendless UI-Builder. Therefore, a user cannot switch to another programming language while using the editor. |
There was a problem hiding this comment.
Therefore, a user cannot switch to another programming language while using the editor.
It's not completely true. We could add the Logic for change language dynamically.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.